Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHEMH-184: Darkened the secondary nav link color #81

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

jenbreese
Copy link
Collaborator

@jenbreese jenbreese commented Nov 27, 2023

READY FOR REVIEW

  • Color oked from Dena/client

Summary

  • Changed the light stone to the darker stone for secondary menu links

Review By (Date)

  • soon

Criticality

  • normal

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Build some test pages.
  4. add them to a page as subpages
  5. Navigate to subpages
  6. Verify the color change
  7. Verify only on secondary menus.
  8. verify filter by menu ok.

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- CHEMH-184

Resources

@buttonwillowsix buttonwillowsix self-assigned this Dec 2, 2023
Copy link
Contributor

@buttonwillowsix buttonwillowsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and it is approved by the client!

@buttonwillowsix
Copy link
Contributor

@jenbreese this appears to have a merge conflict. Can I get a hand resolving that?

@jenbreese
Copy link
Collaborator Author

@jenbreese this appears to have a merge conflict. Can I get a hand resolving that?

Yes, I will do that! Thank you for pointing it out.

@buttonwillowsix buttonwillowsix merged commit 29872a1 into 2.x Jan 17, 2024
1 check passed
@buttonwillowsix buttonwillowsix deleted the CHEMH-184--a11y-color branch January 17, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants